Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ksqldb-client-api): fix describeConnector issued query #10151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bas-velthuizen
Copy link

This PR fixes issue #10150
Also, the unit test is made more strict to test for correct query

Description

The ClientImpl.describeConnector method does not add quotes around the connector name.
This fix adds the quotes.

Testing done

The unit test has been expanded to verify the issued query.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

This PR fixes issue confluentinc#10150
Also, the unit test is made more strict to test for correct query
@bas-velthuizen bas-velthuizen requested a review from a team as a code owner December 5, 2023 13:33
Copy link

cla-assistant bot commented Dec 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Dec 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Bas Velthuizen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bas-velthuizen-alfen
Copy link

Jenkins seems to be failing, but I cannot get the current master of the repo to build on my own system, so I cannot check that.
With version 7.5.2 as a base, the build did succeed locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants