Enable exactOptionalPropertyTypes #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
changed the title
bufdev
changed the title
|
|
|
Let's enable exactOptionalPropertyTypes when it becomes the default with TSC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To quote from the TypeScript team lead:
This configuration brings a pretty critical element to the type-soundness (critical because it drastically changes the behavior of operations that check for keys). SameValueZero checks remain unchanged, anyway, so there's basically no downside to having this rule enabled. The microsoft/TypeScript#43947 from Anders provides some more context, as well.
Thankfully, this codebase was already pretty close to the mark, with only a few little minor things to update to increase strictness. Note a similar PR: bufbuild/protobuf-es#431