Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pins Connect-ES to TypeScript 5.0.3 for the time being. The repo is seeing test failures with 5.1 and this will pin to the working version until we can further investigate.
The failing test is
should leave source dangling
inpackages/connect/src/protocol/async-iterable.spec.ts
, which is relying on thefinally
not being called. Upgrading to 5.1 results infinally
getting invoked and the expected array being of size 2.FWIW, the 5.1 behavior may actually be the correct behavior and it could be this test is relying on a fixed bug.
For additonal reading, see:
for await
transform incorrectly callsreturn
whennext
throws microsoft/TypeScript#50525