Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin TypeScript to 5.0.3 #675

Merged
merged 1 commit into from Jun 14, 2023
Merged

Pin TypeScript to 5.0.3 #675

merged 1 commit into from Jun 14, 2023

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Jun 14, 2023

This pins Connect-ES to TypeScript 5.0.3 for the time being. The repo is seeing test failures with 5.1 and this will pin to the working version until we can further investigate.

The failing test is should leave source dangling in packages/connect/src/protocol/async-iterable.spec.ts, which is relying on the finally not being called. Upgrading to 5.1 results in finally getting invoked and the expected array being of size 2.

FWIW, the 5.1 behavior may actually be the correct behavior and it could be this test is relying on a fixed bug.

For additonal reading, see:

@smaye81 smaye81 requested a review from timostamm June 14, 2023 17:57
@smaye81 smaye81 merged commit db0953d into main Jun 14, 2023
4 checks passed
@smaye81 smaye81 deleted the sayers/pin_ts_5.0.3 branch June 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants