Support CommonJS in protoc-gen-connect-es #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
requested review from
smaye81 and
a team
and removed request for
a team
smaye81
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to @bufbuild/protoplugin v1.6.0 and support CommonJS with the new plugin option:
js_import_styleBy default, protoc-gen-connect-es (and all other plugins based on @bufbuild/protoplugin) generate ECMAScript
importandexportstatements. For use cases where CommonJS is difficult to avoid, this option can be used to generate CommonJSrequire()calls.Possible values:
js_import_style=modulegenerate ECMAScriptimport/exportstatements - the default behavior.js_import_style=legacy_commonjsgenerate CommonJSrequire()calls.