-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #16
Open
petrduda
wants to merge
12
commits into
consistence:master
Choose a base branch
from
petrduda:pd-refactor-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrduda
commented
Mar 10, 2023
•
edited
edited
- stop calling static methods in tests as non-static
- use assertSame() where assertEquals() is not explicitly needed
- use assertCount() after assertContains() for array comparison
- add missing Assert::fail() in try+catch blocks when expecting exceptions
- unify Assert::fail() message
- replace Consistence\TestCase::ok() with expectNotToPerformAssertions()
- use try+catch+fail when expecting exceptions with properties
- rename data providers to singular where applicable
- use DataProvider suffix for data providers
- change data provider return type from array to Generator
- declare data provider values on separate lines
- isolate data provider cases using Closures
- name data provider values
- name data provider cases
- extract multiple cases from test methods to data providers
- remove unnecessary private methods for creating mocks
30bf3d9
to
ada7bc4
Compare
VasekPurchart
requested changes
Apr 13, 2023
ada7bc4
to
2eb246a
Compare
VasekPurchart
requested changes
Apr 21, 2023
tests/MetadataSource/Annotation/AnnotationMetadataSourceTest.php
Outdated
Show resolved
Hide resolved
2eb246a
to
1d33fe8
Compare
VasekPurchart
requested changes
Apr 24, 2023
tests/MetadataSource/Annotation/AnnotationMetadataSourceTest.php
Outdated
Show resolved
Hide resolved
1d33fe8
to
d5359b3
Compare
VasekPurchart
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.