More reliably reset raw mode

console-rs · May 21, 2023 · 2ebd77b · 2ebd77b
1 parent 55e4762
commit 2ebd77b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 23 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 * Set an appropriate lower version of libc for macos changes.
 * Improved behavior of `read_single_key` so it does not disturb other
   threads quite as much. (#165)
+* More reliably reset raw mode in terminal.
 
 ## 0.15.6
 

diff --git a/src/unix_term.rs b/src/unix_term.rs
@@ -202,28 +202,8 @@ fn read_bytes(fd: i32, buf: &mut [u8], count: u8) -> io::Result<u8> {
     }
 }
 
-pub fn read_single_key() -> io::Result<Key> {
-    let tty_f;
-    let fd = unsafe {
-        if libc::isatty(libc::STDIN_FILENO) == 1 {
-            libc::STDIN_FILENO
-        } else {
-            tty_f = fs::OpenOptions::new()
-                .read(true)
-                .write(true)
-                .open("/dev/tty")?;
-            tty_f.as_raw_fd()
-        }
-    };
-    let mut termios = core::mem::MaybeUninit::uninit();
-    c_result(|| unsafe { libc::tcgetattr(fd, termios.as_mut_ptr()) })?;
-    let mut termios = unsafe { termios.assume_init() };
-    let original = termios;
-    unsafe { libc::cfmakeraw(&mut termios) };
-    termios.c_oflag = original.c_oflag;
-    c_result(|| unsafe { libc::tcsetattr(fd, libc::TCSADRAIN, &termios) })?;
-
-    let rv: io::Result<Key> = loop {
+fn read_single_key_impl(fd: i32) -> Result<Key, io::Error> {
+    loop {
         match read_single_char(fd)? {
             Some('\x1b') => {
                 // Escape was read, keep reading in case we find a familiar key
@@ -312,8 +292,30 @@ pub fn read_single_key() -> io::Result<Key> {
                 }
             }
         }
-    };
+    }
+}
 
+pub fn read_single_key() -> io::Result<Key> {
+    let tty_f;
+    let fd = unsafe {
+        if libc::isatty(libc::STDIN_FILENO) == 1 {
+            libc::STDIN_FILENO
+        } else {
+            tty_f = fs::OpenOptions::new()
+                .read(true)
+                .write(true)
+                .open("/dev/tty")?;
+            tty_f.as_raw_fd()
+        }
+    };
+    let mut termios = core::mem::MaybeUninit::uninit();
+    c_result(|| unsafe { libc::tcgetattr(fd, termios.as_mut_ptr()) })?;
+    let mut termios = unsafe { termios.assume_init() };
+    let original = termios;
+    unsafe { libc::cfmakeraw(&mut termios) };
+    termios.c_oflag = original.c_oflag;
+    c_result(|| unsafe { libc::tcsetattr(fd, libc::TCSADRAIN, &termios) })?;
+    let rv: io::Result<Key> = read_single_key_impl(fd);
     c_result(|| unsafe { libc::tcsetattr(fd, libc::TCSADRAIN, &original) })?;
 
     // if the user hit ^C we want to signal SIGINT to outselves.