Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating all dependencies #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

allohamora
Copy link

I updated all dependencies for fix npm audit vulnerabilities.

@the-homeless-god
Copy link

@constverum PTAL

@virtual
Copy link

virtual commented Aug 2, 2021

Confirmed this worked great for my project. :)

@Stanzilla
Copy link

Stanzilla commented Jan 21, 2022

@mor10 This probably can't be merged because it switched from yarn to npm, would you be willing to merge a PR that bumps everything without doing the switch?

@the-homeless-god
Copy link

@mor10 This probably can't be merged because it switched from yarn to npm, would you be willing to merge a PR that bumps everything without doing the switch?

could you tell us what's reason to save yarn?

@Stanzilla
Copy link

@mor10 This probably can't be merged because it switched from yarn to npm, would you be willing to merge a PR that bumps everything without doing the switch?

could you tell us what's reason to save yarn?

Not really but there is no reason to change this as it was the maintainer's preferred choice and is not in scope for a pull request that just updates dependency versions.

@mor10
Copy link
Contributor

mor10 commented Jan 21, 2022

Why am I included in this? It's not my PR and not my repo.

@Stanzilla
Copy link

Why am I included in this? It's not my PR and not my repo.

Oh sorry, I thought you're a contributor judging from the other conversations.

Guess we'll have to wait for @constverum then!

@mor10
Copy link
Contributor

mor10 commented Jan 21, 2022

I'm just a regular person with opinions. I have no power (in this project). Hope the PR gets merged though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants