Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention about the possibilities of using staging_target_path at NodeStage #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 31, 2019

At present, it is unclear to SP that, how to use staging_target_path
and the possibilities of using the same. This patch add more details
on staging target path and its usage.

Fix # #385

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@humblec
Copy link
Contributor Author

humblec commented Aug 31, 2019

/assign @msau42

@shay-berman
Copy link

I think its a good clarification.
We actually use the staging target path to store metadata file (with the discovered multipath device), in order to have that metadata during the NodePublishVolume(uses the metadata file to operate the l mkfs+mount it to target path) and for NodeUnStage (uses the metadata to clean up the multipath device).

So I think its good clarification that staging_target_path can be used for CSI driver metadata for example.

…tage.

At present, it is unclear to SP that, how to use staging_target_path
and the possibilities of using the same. This patch add more details
on `staging target path` and its usage.

Fix # container-storage-interface#385

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Sep 5, 2019

@saad-ali

@msau42
Copy link

msau42 commented Sep 5, 2019

/assign @saad-ali

spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
Signed-off-by: hchiramm <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Apr 23, 2020

@saad-ali @msau42 can you please review ?

@saad-ali
Copy link
Member

I have no objections to this. But please bring it up at the next CSI meeting, would be good to get more eyeballs on this before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants