capacity_range error description for CreateVolumeRequest was impoved #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r `CreateVolumeRequest` was improved
saad-ali
reviewed
May 27, 2020
| @@ -1161,7 +1161,7 @@ The CO MUST implement the specified error recovery behavior when it encounters t | |||
| | Source does not exist | 5 NOT_FOUND | Indicates that the specified source does not exist. | Caller MUST verify that the `volume_content_source` is correct, the source is accessible, and has not been deleted before retrying with exponential back off. | | |||
| | Volume already exists but is incompatible | 6 ALREADY_EXISTS | Indicates that a volume corresponding to the specified volume `name` already exists but is incompatible with the specified `capacity_range`, `volume_capabilities` or `parameters`. | Caller MUST fix the arguments or use a different `name` before retrying. | | |||
| | Unable to provision in `accessible_topology` | 8 RESOURCE_EXHAUSTED | Indicates that although the `accessible_topology` field is valid, a new volume can not be provisioned with the specified topology constraints. More human-readable information MAY be provided in the gRPC `status.message` field. | Caller MUST ensure that whatever is preventing volumes from being provisioned in the specified location (e.g. quota issues) is addressed before retrying with exponential backoff. | | |||
| | Unsupported `capacity_range` | 11 OUT_OF_RANGE | Indicates that the capacity range is not allowed by the Plugin, for example when trying to create a volume smaller than the source snapshot. More human-readable information MAY be provided in the gRPC `status.message` field. | Caller MUST fix the capacity range before retrying. | | |||
| | Unsupported `capacity_range` | 11 OUT_OF_RANGE | Indicates that the capacity range is not allowed by the Plugin, for example when trying to create a volume smaller than the source snapshot or when a plugin does not have defaults to handle the request with `capacity_range` not having being set. More human-readable information MAY be provided in the gRPC `status.message` field. | Caller MUST fix the capacity range before retrying or MUST ensure plugin for being reconfigured with meaningful defaults. | | |||
There was a problem hiding this comment.
Suggested change
| | Unsupported `capacity_range` | 11 OUT_OF_RANGE | Indicates that the capacity range is not allowed by the Plugin, for example when trying to create a volume smaller than the source snapshot or when a plugin does not have defaults to handle the request with `capacity_range` not having being set. More human-readable information MAY be provided in the gRPC `status.message` field. | Caller MUST fix the capacity range before retrying or MUST ensure plugin for being reconfigured with meaningful defaults. | | |
| | Unsupported `capacity_range` | 11 OUT_OF_RANGE | Indicates the specified `capacity_range` is not allowed by the SP (for example when trying to create a volume smaller than the source snapshot) or `capacity_range` is not specified while the SP requires it. More human-readable information MAY be provided in the gRPC `status.message` field. | Caller MUST fix the capacity range before retrying. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #413 and CSI community meeting notes added on 2/11/20, This specific case with empty
capacity_rangewas added to theCreateVolumeRequesterrors table.