describe what if topology not match exactly #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdef
reviewed
Mar 12, 2024
There was a problem hiding this comment.
I believe that this PR clarifies the original intent of topology matching, thanks!
I'm undecided on the risk factor, and have limited brain cycles to spend here at the moment. Curious if anyone else in the community is concerned about potential breakage this language change might imply.
spec.md
Outdated
| @@ -1050,6 +1050,11 @@ message Volume { | |||
| // COs MAY use this information along with the topology information | |||
| // returned by NodeGetInfo to ensure that a given volume is accessible | |||
| // from a given node when scheduling workloads. | |||
| // The volume is accessible from all locations in the | |||
| // specified topology. | |||
| // The volume is accessible from a node if the volume's | |||
There was a problem hiding this comment.
... from a node if at least one of the volume's accessible topologies is a superset of ...
because a volume can have multiple accessible topologies
There was a problem hiding this comment.
I've added "union of", since I am already using the term of set theory.
spec.md
Outdated
| // The node can access some of the locations in the | ||
| // specified topology. | ||
| // The node can access a volume if the node's accessible_topology | ||
| // is a subset of the volume's accessible_topology. |
There was a problem hiding this comment.
.. is a subset of at least one of the volume's accessible topologies.
Describe what to expect when the accessible_topology of node and volume does not match exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Describe what to expect when the accessible_topology of node and volume does not match exactly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: