Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Wally #2249

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

guidojw
Copy link

@guidojw guidojw commented Feb 24, 2024

Adds support for the Wally package manager.
renovatebot/renovate#25339

Installing Wally on Ubuntu focal will cause libssl errors. I tried installing the correct libssl here in a prepare class but that was too much of a hassle where it needs jammy apt sources in order to even be able to find the version, but for its dependencies too, so in the end I made it throw an error instead.

@guidojw guidojw force-pushed the feat/wally-tool branch 2 times, most recently from 8b7f90e to 8404e0c Compare February 24, 2024 21:03
@guidojw
Copy link
Author

guidojw commented Feb 24, 2024

Because of the focal limitation, this PR is blocked by #1991.

@rarkins rarkins requested a review from viceice February 25, 2024 06:12
@rarkins
Copy link
Member

rarkins commented Feb 25, 2024

@guidojw do you mean that wally will only work on Ubuntu 22.04?

@guidojw
Copy link
Author

guidojw commented Feb 25, 2024

@guidojw do you mean that wally will only work on Ubuntu 22.04?

Yes, Wally only works with libssl3 and focal comes with 1.1.
I tried installing 3 on focal but this meant pointing apt repositories for libssl specifically to the jammy ones, which worked but then it started erroring about libc6 also not being the right version.
I could point libc6 to jammy repositories too but read online that this is not a good idea because lots of os components might depend on it.

@rarkins
Copy link
Member

rarkins commented Feb 25, 2024

Right now we're still defaulting to Ubuntu 20 for our builds I think

@guidojw
Copy link
Author

guidojw commented Feb 25, 2024

Yeah, #1991 should be the only thing blocking this right? I'll convert to draft until that is merged

@guidojw guidojw marked this pull request as draft February 25, 2024 15:53
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you validated that wally uses system libssl and doesn't include it?

@@ -190,7 +190,7 @@ RUN prepare-tool all
RUN set -ex; [ -d /usr/local/erlang ] && echo "works" || exit 1;

#--------------------------------------
# test: bazelisk, bun, vendir, helmfile, kustomize
# test: bazelisk, bun, gleam, helmfile, kustomize, vendir, wally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a seperate refactor PR for the reorderings

RUN set -ex; vendir --version
RUN install-tool vendir "v${VENDIR_VERSION}"

RUN install-tool wally "v${WALLY_VERSION}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probabbly fail, because latest depends on 20.04

@viceice viceice added the status:blocked Issue is blocked by another issue or external requirement label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:blocked Issue is blocked by another issue or external requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants