-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Wally #2249
base: main
Are you sure you want to change the base?
feat: add Wally #2249
Conversation
8b7f90e
to
8404e0c
Compare
8404e0c
to
4e76c0c
Compare
Because of the focal limitation, this PR is blocked by #1991. |
@guidojw do you mean that wally will only work on Ubuntu 22.04? |
Yes, Wally only works with libssl3 and focal comes with 1.1. |
Right now we're still defaulting to Ubuntu 20 for our builds I think |
Yeah, #1991 should be the only thing blocking this right? I'll convert to draft until that is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you validated that wally uses system libssl and doesn't include it?
@@ -190,7 +190,7 @@ RUN prepare-tool all | |||
RUN set -ex; [ -d /usr/local/erlang ] && echo "works" || exit 1; | |||
|
|||
#-------------------------------------- | |||
# test: bazelisk, bun, vendir, helmfile, kustomize | |||
# test: bazelisk, bun, gleam, helmfile, kustomize, vendir, wally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create a seperate refactor PR for the reorderings
RUN set -ex; vendir --version | ||
RUN install-tool vendir "v${VENDIR_VERSION}" | ||
|
||
RUN install-tool wally "v${WALLY_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will probabbly fail, because latest depends on 20.04
Adds support for the Wally package manager.
renovatebot/renovate#25339
Installing Wally on Ubuntu focal will cause libssl errors. I tried installing the correct libssl here in a prepare class but that was too much of a hassle where it needs jammy apt sources in order to even be able to find the version, but for its dependencies too, so in the end I made it throw an error instead.