Skip to content

Commit

Permalink
CI: Explicitly upgrade MinGW on Windows 2019 GitHub runners.
Browse files Browse the repository at this point in the history
The default version of MinGW and GCC on the GitHub-hosted Windows 2019
runners compile fine but lead to linker errors during runtime.

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
(cherry picked from commit c883410)
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
  • Loading branch information
aznashwan authored and akhilerm committed Mar 4, 2024
1 parent 5b23a41 commit 9e24388
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,13 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/install-go

# NOTE(aznashwan): starting with Golang 1.21, the windows-2019 GitHub runner's
# builtin MinGW version leads to DLL loading errors during runtime.
- name: Upgrade MinGW on Windows 2019
if: matrix.os == 'windows-2019'
run: choco upgrade mingw

- name: Make
run: |
make build
Expand Down Expand Up @@ -244,6 +251,12 @@ jobs:
- run: script/setup/install-dev-tools

# NOTE(aznashwan): starting with Golang 1.21, the windows-2019 GitHub runner's
# builtin MinGW version leads to DLL loading errors during runtime.
- name: Upgrade MinGW on Windows 2019
if: matrix.os == 'windows-2019'
run: choco upgrade mingw

- name: Binaries
env:
CGO_ENABLED: 1
Expand Down

0 comments on commit 9e24388

Please sign in to comment.