Propagate trace contexts to shims #10186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
propagate_traces_to_shim
branch
4 times, most recently
from
486b0a5
to
1898361
Compare
mxpv
reviewed
May 7, 2024
cmd/containerd-shim-runc-v2/main.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| "github.com/containerd/containerd/v2/cmd/containerd-shim-runc-v2/manager" | |||
| _ "github.com/containerd/containerd/v2/cmd/containerd-shim-runc-v2/task/plugin" | |||
| "github.com/containerd/containerd/v2/pkg/shim" | |||
| _ "github.com/containerd/containerd/v2/pkg/tracing/plugin" | |||
There was a problem hiding this comment.
I wonder how this affects the output binary size?
Context: #9233 (comment)
There was a problem hiding this comment.
Looks like ~2MB larger with this import :(
There was a problem hiding this comment.
I'm fine leaving this out (or gated by a tag for debugging purposes?).
Mainly added it to see things working and found it didn't really seem to have an impact in memory usage so I kept it in.
There was a problem hiding this comment.
Seems like its easy to hide it with a build tag.
There was a problem hiding this comment.
Eventually we should find a way to drop grpc dependency from the runc shim.
There was a problem hiding this comment.
Gated this by the shim_tracing tag.
cpuguy83
force-pushed
the
propagate_traces_to_shim
branch
3 times, most recently
from
a3d8890
to
d3b91c9
Compare
mxpv
approved these changes
May 9, 2024
This adds trace context propagation over the grpc/ttrpc calls to a shim. It also adds the otlp plugin to the runc shim so that it will send traces to the configured tracer (which is inherited from containerd's config). It doesn't look like this is adding any real overhead to the runc shim's memory usage, however it does add 2MB to the binary size. As such this is gated by a build tag `shim_tracing` Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
propagate_traces_to_shim
branch
from
d3b91c9
to
2c694a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds trace context propagation over the grpc/ttrpc calls to a shim.
It also adds the otlp plugin to the runc shim so that it will send traces to the configured tracer (which is inherited from containerd's config).
It doesn't look like this is adding any real overhead to the runc shim's memory usage.