[release/1.7] Add API go module #10189
Open
+37,797
−486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
dmcgowan
force-pushed
the
1.7-api-go-module
branch
2 times, most recently
from
41cb738
to
7ee92ff
Compare
dmcgowan
force-pushed
the
1.7-api-go-module
branch
from
7ee92ff
to
ddc2a76
Compare
dmcgowan
force-pushed
the
1.7-api-go-module
branch
from
ddc2a76
to
943a70a
Compare
|
Let's get this one into the next 1.7 release |
dmcgowan
force-pushed
the
1.7-api-go-module
branch
from
943a70a
to
5be6019
Compare
Signed-off-by: Akhil Mohan <akhilerm@gmail.com> (cherry picked from commit b16e357) Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Allows the api version to be imported and upgraded separately from the main module. Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit e69efd5) Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
1.7-api-go-module
branch
from
5be6019
to
4a2ca38
Compare
|
Trying this PR in moby/moby (through a replace rule), but looks like it's not happy. Perhaps I need to force a version for the API module, or something else (or the API package must have aliases in it; or removed, not sure; |
|
OH! Maybe it works; but it's just version resolution; I manually added the API module, and that ... seems to go better. Only now it enforces go1.22, because that's what the API module defines? Line 3 in 114ef75 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add api go module to 1.7. The plan is we do not need to update 1.7 to the 1.8 api go module if we separate it into its like we have done with main. The changes needed are minimal.
This helps the upgrade path from 1.7 to 2.0. After updating to 1.7, it should be easier to update to 2.0 since the api module can be just be upgraded to 1.8 and the latest containerd 1.7 will use the api package from the module.
For those not upgrading to 2.0 right away, the change should be invisible beside an extra dependency showing up in go module. We shouldn't need to do this for 1.6 since this only effects importers who are upgrading. In cases where an import is trying to stay on 1.6 but a dependency uses the latest version of 1.7, go mod would already forces the upgrade anyway.