Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] ctr: print deprecation warnings on every invocation #9820

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[release/1.7] ctr: print deprecation warnings on every invocation #9820

merged 1 commit into from
Feb 14, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda
ctr: print deprecation warnings on every invocation
eaebe23 
Print deprecation warnings on any ctr command, as users won't notice the
deprecations until we actually remove the deprecated features.

The warnings can be suppressed by setting
`CONTAINERD_SUPPRESS_DEPRECATION_WARNINGS=1`.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 468bee9)
(cherry-pick was not clean)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@estesp estesp merged commit 897f94e into containerd:release/1.7 Feb 14, 2024
56 checks passed
@dmcgowan dmcgowan mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@akhilerm akhilerm akhilerm approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AkihiroSuda @samuelkarp @estesp @akhilerm @k8s-ci-robot