Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.7] ci: update crun version to 1.14.3 #9850

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Feb 22, 2024

Changes:
containers/crun@1.14...1.14.3

(cherry picked from commit bd48104)

clean cherry-pick of #9848

Changes:
containers/crun@1.14...1.14.3

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
(cherry picked from commit bd48104)
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm
Copy link
Member Author

@dmcgowan Looks like there is an issue going on with building cri-tools on windows. I can see that the previous post merge run on the 1.7 branch also has failed with same error. https://github.com/containerd/containerd/actions/workflows/ci.yml?query=branch%3Arelease%2F1.7

@dmcgowan
Copy link
Member

We should investigate that, doesn't seem like a temporary failure

This the cause?

Error: vendor\k8s.io\apimachinery\pkg\util\sets\set.go:20:2: package cmp is not in GOROOT (C:\hostedtoolcache\windows\go\1.20.13\x64\src\cmp)
note: imported by a module that requires go 1.21

Not related to this PR though since crun is not Windows related

@akhilerm
Copy link
Member Author

We should investigate that, doesn't seem like a temporary failure

Yes. Its not a temporary failure. The recent merge in the 1.7 branch also had the same issue, so its completely unrelated to the PR.

@mxpv mxpv merged commit 3f7d155 into containerd:release/1.7 Feb 22, 2024
52 of 56 checks passed
@akhilerm akhilerm deleted the cherry-pick-9848-release-1.7 branch February 23, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants