Fix runc update --resources flag usage #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runc's CLI requires --flag=value arg passing. Xref: k3s-io/k3s#3104 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
|
cc @AkihiroSuda |
This is because k3s variant of runc use urfave cli v1.22 urfave/cli#1092 So if you downgrade urfave cli to v1.21 (used by upstream runc) you will no longer see the error. Anyway, this PR is harmless to upstream runc and LGTM |
AkihiroSuda
approved these changes
Mar 23, 2021
fuweid
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runc's CLI requires --flag=value arg passing.
Xref: k3s-io/k3s#3104
Signed-off-by: Brad Davidson brad.davidson@rancher.com