Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to go modules #7

Merged
merged 5 commits into from Jan 6, 2020
Merged

Move to go modules #7

merged 5 commits into from Jan 6, 2020

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Dec 13, 2019

@lumjjb
Copy link
Collaborator

lumjjb commented Dec 17, 2019

@chenrui333 thanks for the PR! Looks good but CI is failing. I believe may be because of this line:

https://github.com/containerd/imgcrypt/blob/master/script/setup/install-runc#L26

It looks like go get behavior is a bit different in 1.13. We can update this to just manually git clone and build runc instead. That should work for our purposes. This will be backward compatible with 1.12 as well. (we can also have both 1.12 and 1.13, that should be fine as well.

vendor.conf looks like it should be removed and this line should reference go.mod instead as well.

https://github.com/containerd/imgcrypt/blob/master/script/setup/install-runc#L24

Which needs to be updated to parse go mod instead of vendor.conf.

@chenrui333
Copy link
Contributor Author

@lumjjb I will spend some time tomorrow on this, too busy today. :)

@lumjjb
Copy link
Collaborator

lumjjb commented Dec 17, 2019

Awesome! No worries. Thanks! :D

@chenrui333
Copy link
Contributor Author

FYI, I will spend more time on this later today or tomorrow. :)

@lumjjb
Copy link
Collaborator

lumjjb commented Jan 2, 2020

@chenrui333 Happy New Year! How are things going?

Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
@chenrui333 chenrui333 force-pushed the go-modules branch 2 times, most recently from 69ba1e5 to ef39ff3 Compare January 6, 2020 04:48
Signed-off-by: Rui Chen <chenrui333@gmail.com>
@chenrui333
Copy link
Contributor Author

@lumjjb Happy new year!!

Signed-off-by: Rui Chen <chenrui333@gmail.com>
Copy link
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@lumjjb lumjjb merged commit 20f0cc0 into containerd:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants