New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to go modules #7
Conversation
@chenrui333 thanks for the PR! Looks good but CI is failing. I believe may be because of this line: https://github.com/containerd/imgcrypt/blob/master/script/setup/install-runc#L26 It looks like go get behavior is a bit different in 1.13. We can update this to just manually git clone and build
https://github.com/containerd/imgcrypt/blob/master/script/setup/install-runc#L24 Which needs to be updated to parse go mod instead of vendor.conf. |
@lumjjb I will spend some time tomorrow on this, too busy today. :) |
Awesome! No worries. Thanks! :D |
FYI, I will spend more time on this later today or tomorrow. :) |
@chenrui333 Happy New Year! How are things going? |
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
69ba1e5
to
ef39ff3
Compare
Signed-off-by: Rui Chen <chenrui333@gmail.com>
@lumjjb Happy new year!! |
Signed-off-by: Rui Chen <chenrui333@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
Issue tracker, containerd/containerd#3031