Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take pkg/hooks from github.com/containers/common (carry 46) #55

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 15, 2023

pkg/hooks was moved from github.com/containers/podman/v4 to github.com/containers/common and it's to much time consuming to keep packaging github.com/containers/podman/v3.


changes compared to the other PR;

  • rebase (we merged the "remove containerd dependency"
  • removed changes from other plugin go mods (keeping the PR focussed on just this change)
  • updated to containers/common v0.56.0 (which uses runtime spec v1.1.0 instead of -rc.3)

pkg/hooks was moved from github.com/containers/podman/v4 to
github.com/containers/common and it's to much time consuming to
keep packaging github.com/containers/podman/v3.

Co-authored-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@thaJeztah
Copy link
Member Author

@mikebrow @klihub @eclipseo ptal 🤗

Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmcgowan dmcgowan merged commit c68cf49 into containerd:main Sep 15, 2023
8 checks passed
@thaJeztah thaJeztah deleted the relocate_hooks_carry branch September 15, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants