Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert back to previous logic of adding ownership to crates.io #380

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Nov 1, 2023

I've done some experiments with cargo owner --add command and apparently that the bot (containerd-runwasi-release-bot) is not able to add github:containerd:runwasi-committers as an owner to the published crate by itself. See https://github.com/containerd/runwasi/actions/runs/6711072386/job/18237873816#step:8:13

However, the bot was able to add the user who triggered the action as an owner to the published crate. See: https://github.com/containerd/runwasi/actions/runs/6714433126/job/18247647749#step:3:26

I want to revert the change back to previous logic to first examine if this published crate already has the desired owner. Otherwise, it adds the user who triggered the action as an owner and the user has then to add github:containerd:runwasi-committers as an owner. This follows the doc in RELEASE.md.

The branch add-owner serves the single purpose of adding myself as an owner to the published containerd-shim-wasm-test-modules crate so that I can add runwasi-committes to its owners. I will delete this branch shortly after.

Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
@Mossaka Mossaka requested a review from cpuguy83 November 2, 2023 01:35
@Mossaka
Copy link
Member Author

Mossaka commented Nov 3, 2023

Could you please review this PR? @jsturtevant @jprendes

@cpuguy83
Copy link
Member

cpuguy83 commented Nov 3, 2023

I think if we add the bot to the committers group it should be able to work.
Most likely since it is not part of the group it can't even see the group.

@jprendes
Copy link
Collaborator

jprendes commented Nov 3, 2023

I think this is the same error message as in
rust-lang/crates.io#3031

@Mossaka
Copy link
Member Author

Mossaka commented Nov 3, 2023

@cpuguy83 can you do that for the bot account? I assume that only you have the crendentials for it.

@cpuguy83
Copy link
Member

cpuguy83 commented Nov 3, 2023

I'll take a look.
I think we'll also need to login as the release bot in CI.

@Mossaka Mossaka marked this pull request as draft November 4, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants