Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making tracaing::instrument macro optional #592

Merged
merged 2 commits into from
May 22, 2024
Merged

making tracaing::instrument macro optional #592

merged 2 commits into from
May 22, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented May 18, 2024

Closes #591

@Mossaka
make tracing optional
6d36c14 
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
@Mossaka
use cfg_attr to replace proc-macro in tracing instrument
912fd6d 
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
@Mossaka Mossaka marked this pull request as ready for review May 20, 2024 18:31
@Mossaka Mossaka requested a review from jsturtevant May 20, 2024 18:31
jsturtevant
jsturtevant approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsturtevant jsturtevant merged commit d970d9f into containerd:main May 22, 2024
51 checks passed
@Mossaka Mossaka deleted the tracing-optional branch May 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider making the Tracing support optional in the shims
2 participants
@Mossaka @jsturtevant