Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in comment for UserOnCloseWait. #153

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

klihub
Copy link
Member

@klihub klihub commented Jul 27, 2023

While looking at client.go:UserOnCloseWait() based on a review comment for #150, I spotted something that looks like grammar errors in a docstring comment which then ends up being part of the package documentation here.

Can some of the native speakers double-check that I didn't simply trade a grammar error for another one ?

@klihub klihub requested a review from estesp July 27, 2023 15:38
@klihub klihub changed the title Fix grammer in comment for UserOnCloseWait. Fix grammar in comment for UserOnCloseWait. Jul 27, 2023
@klihub klihub force-pushed the fixes/UserOnCloseWait-comment branch from 76f0c44 to fd0dff6 Compare July 27, 2023 15:52
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch; your edit is correct

@klihub
Copy link
Member Author

klihub commented Jul 27, 2023

And I think the CI errors we see here are fixed by #150. Once we get that merged, I can rebase this and it should make those errors go away.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the fixes/UserOnCloseWait-comment branch from fd0dff6 to 8ca4110 Compare July 28, 2023 17:02
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit b2f0ada into containerd:main Aug 7, 2023
11 checks passed
@klihub klihub deleted the fixes/UserOnCloseWait-comment branch August 10, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants