Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump genproto dependency #154

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Bump genproto dependency #154

merged 2 commits into from
Aug 7, 2023

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 2, 2023

This updates the genproto dependency to a version that carves out the rpc subpackage, reducing the surface area relied on by this library

See googleapis/go-genproto#1015 for more details

Signed-off-by: Jordan Liggitt <liggitt@google.com>
…14-cbb8c96f2d6d

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt
Copy link
Contributor Author

liggitt commented Aug 7, 2023

I cannot reproduce the test failure locally:

$ go version
go version go1.20.6 linux/amd64

$ make coverage TESTFLAGS_RACE=-race
🇩 coverage
?   	github.com/containerd/ttrpc/internal	[no test files]
?   	github.com/containerd/ttrpc/plugin	[no test files]
ok  	github.com/containerd/ttrpc	1.290s
ok  	github.com/containerd/ttrpc	1.504s	coverage: 65.9% of statements
?   	github.com/containerd/ttrpc/cmd/protoc-gen-go-ttrpc	[no test files]
?   	github.com/containerd/ttrpc/cmd/protoc-gen-gogottrpc	[no test files]
ok  	github.com/containerd/ttrpc/integration	0.123s	coverage: [no statements]
?   	github.com/containerd/ttrpc/integration/streaming	[no test files]
?   	github.com/containerd/ttrpc/internal	[no test files]
?   	github.com/containerd/ttrpc/plugin	[no test files]

$ go test -race -v github.com/containerd/ttrpc -count=10
=== RUN   TestReadWriteMessage
--- PASS: TestReadWriteMessage (0.00s)
=== RUN   TestMessageOversize
--- PASS: TestMessageOversize (0.11s)
=== RUN   TestUserOnCloseWait
--- PASS: TestUserOnCloseWait (1.00s)
=== RUN   TestMetadataGet
--- PASS: TestMetadataGet (0.00s)
=== RUN   TestMetadataGetInvalidKey
--- PASS: TestMetadataGetInvalidKey (0.00s)
=== RUN   TestMetadataUnset
--- PASS: TestMetadataUnset (0.00s)
=== RUN   TestMetadataReplace
--- PASS: TestMetadataReplace (0.00s)
=== RUN   TestMetadataAppend
--- PASS: TestMetadataAppend (0.00s)
=== RUN   TestMetadataContext
--- PASS: TestMetadataContext (0.00s)
=== RUN   TestUnixSocketHandshake
--- PASS: TestUnixSocketHandshake (0.00s)
=== RUN   TestServerEOF
--- PASS: TestServerEOF (0.10s)
=== RUN   TestServer
--- PASS: TestServer (0.00s)
=== RUN   TestServerUnimplemented
--- PASS: TestServerUnimplemented (0.00s)
=== RUN   TestServerListenerClosed
--- PASS: TestServerListenerClosed (0.00s)
=== RUN   TestServerShutdown
--- PASS: TestServerShutdown (0.00s)
=== RUN   TestServerClose
--- PASS: TestServerClose (0.00s)
=== RUN   TestOversizeCall
--- PASS: TestOversizeCall (0.12s)
=== RUN   TestClientEOF
--- PASS: TestClientEOF (0.00s)
=== RUN   TestServerRequestTimeout
--- PASS: TestServerRequestTimeout (0.00s)
=== RUN   TestServerConnectionsLeak
--- PASS: TestServerConnectionsLeak (0.00s)
=== RUN   Test_MethodFullNameGeneration
--- PASS: Test_MethodFullNameGeneration (0.00s)
=== RUN   TestStreamClient
--- PASS: TestStreamClient (0.01s)
PASS
ok  	github.com/containerd/ttrpc	1.443s

$ go test -v -race github.com/containerd/ttrpc -count=1
=== RUN   TestReadWriteMessage
--- PASS: TestReadWriteMessage (0.00s)
=== RUN   TestMessageOversize
--- PASS: TestMessageOversize (0.11s)
=== RUN   TestUserOnCloseWait
--- PASS: TestUserOnCloseWait (1.00s)
=== RUN   TestMetadataGet
--- PASS: TestMetadataGet (0.00s)
=== RUN   TestMetadataGetInvalidKey
--- PASS: TestMetadataGetInvalidKey (0.00s)
=== RUN   TestMetadataUnset
--- PASS: TestMetadataUnset (0.00s)
=== RUN   TestMetadataReplace
--- PASS: TestMetadataReplace (0.00s)
=== RUN   TestMetadataAppend
--- PASS: TestMetadataAppend (0.00s)
=== RUN   TestMetadataContext
--- PASS: TestMetadataContext (0.00s)
=== RUN   TestUnixSocketHandshake
--- PASS: TestUnixSocketHandshake (0.00s)
=== RUN   TestServerEOF
--- PASS: TestServerEOF (0.10s)
=== RUN   TestServer
--- PASS: TestServer (0.00s)
=== RUN   TestServerUnimplemented
--- PASS: TestServerUnimplemented (0.00s)
=== RUN   TestServerListenerClosed
--- PASS: TestServerListenerClosed (0.00s)
=== RUN   TestServerShutdown
--- PASS: TestServerShutdown (0.20s)
=== RUN   TestServerClose
--- PASS: TestServerClose (0.00s)
=== RUN   TestOversizeCall
--- PASS: TestOversizeCall (0.07s)
=== RUN   TestClientEOF
--- PASS: TestClientEOF (0.00s)
=== RUN   TestServerRequestTimeout
--- PASS: TestServerRequestTimeout (0.00s)
=== RUN   TestServerConnectionsLeak
--- PASS: TestServerConnectionsLeak (0.00s)
=== RUN   Test_MethodFullNameGeneration
--- PASS: Test_MethodFullNameGeneration (0.00s)
=== RUN   TestStreamClient
--- PASS: TestStreamClient (0.01s)
PASS
...
ok  	github.com/containerd/ttrpc	13.410s

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 9287d49 into containerd:main Aug 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants