Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #493

Closed
wants to merge 1 commit into from
Closed

Update all dependencies #493

wants to merge 1 commit into from

Conversation

redhat-renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Update Change
regex minor ==2024.4.28 -> ==2024.5.10
tenacity minor ==8.2.3 -> ==8.3.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

mrabarnett/mrab-regex (regex)

v2024.5.10

Compare Source

jd/tenacity (tenacity)

v8.3.0

Compare Source

New Features

  • Added a new stop function: stop_before_delay, which will stop execution if the next sleep time would cause overall delay to exceed the specified delay. Useful for use cases where you have some upper bound on retry times that you must not exceed, so returning before that timeout is preferable than returning after that timeout.

Bug Fixes

  • Preserve defaults and kwdefaults through retry decorator

Other Notes

  • Add a "test" extra

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Signed-off-by: Platform Engineering Bot <platform-engineering@redhat.com>
@redhat-renovate-bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

@lmilbaum @Gregory-Pereira We need to have the DCO check ignore renovate PRs.

@lmilbaum
Copy link
Collaborator

@lmilbaum @Gregory-Pereira We need to have the DCO check ignore renovate PRs.

This is a renovate defect which should be handled there

@gnaponie
Copy link

Hello,
checking the error in the CI it seems like it was not signed correctly. It was expecting to be signed by the redhat-renovate-bot service account (which filed the PR), but it got signed as "platform-engineering". From a quick check I believe the problem is in your preset, which is configured in your renovate local configuration: .github/renovate.json5
This file is pointing to this preset: https://github.com/platform-engineering-org/.github/blob/main/default.json#L75

Which is specifying the platform-engineering bot as gitAuthor (which is the old service account).
My suggestion is that you remove those lines from your preset, so that it will consider the global configuration instead.
Let me know if I can help you further with that.

@lmilbaum
Copy link
Collaborator

Hello, checking the error in the CI it seems like it was not signed correctly. It was expecting to be signed by the redhat-renovate-bot service account (which filed the PR), but it got signed as "platform-engineering". From a quick check I believe the problem is in your preset, which is configured in your renovate local configuration: .github/renovate.json5 This file is pointing to this preset: https://github.com/platform-engineering-org/.github/blob/main/default.json#L75

Which is specifying the platform-engineering bot as gitAuthor (which is the old service account). My suggestion is that you remove those lines from your preset, so that it will consider the global configuration instead. Let me know if I can help you further with that.

Thank you for your feedback. Would you mind contributing the change that you suggested?

@lmilbaum
Copy link
Collaborator

Closing this ticket per renovate changes I'm working on

@lmilbaum lmilbaum closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants