Windows: install dotnet and latest wix #354
Conversation
lsm5
added
no_skopeo_cidev
lsm5
force-pushed
the
dotnet
branch
6 times, most recently
from
3561082
to
ff3089d
Compare
|
Cirrus CI build successful. Found built image names and IDs:
|
lsm5
removed
no_skopeo_cidev
win_images/win_packaging.ps1
Outdated
| # dotnet is required for wixtoolset | ||
| # Allowing chocolaty to install dotnet breaks in an entirely | ||
| # non-debuggable way. Workaround this by installing it as | ||
| # a server-feature first. | ||
| Install-WindowsFeature -Name Net-Framework-Core; Check-Exit | ||
| #Install-WindowsFeature -Name Net-Framework-Core; Check-Exit | ||
|
|
||
| # Install wixtoolset for installer build & test. | ||
| retryInstall wixtoolset; Check-Exit | ||
| #retryInstall wixtoolset; Check-Exit |
There was a problem hiding this comment.
Assuming what you added above works, my preference would be to just delete all this commented out stuff. Otherwise anybody else finding this is going to wonder "why" - which isn't commented anywhere. It's okay to rely on git to remember these commands if we ever need them again.
There was a problem hiding this comment.
Ack, I'll remove those after testing the built image in the podman windows installer PR. Thanks a lot
cevich
removed
the
no_fedora-podman-aws-arm64
|
Assuming you want to build AWS arm Fedora. |
lsm5
force-pushed
the
dotnet
branch
2 times, most recently
from
cb66bae
to
339881f
Compare
|
Win-images build successful, now to wait to test the new image id in the podman PR. |
|
Cirrus CI build successful. Found built image names and IDs:
|
win_images/win_packaging.ps1
Outdated
|
|
||
| # Install wixtoolset for installer build & test. | ||
| retryInstall wixtoolset; Check-Exit | ||
| # Install dotnet |
There was a problem hiding this comment.
This is an "add one to X" comment. If you need to repush, could you please use comments to explain the why, not the what? Even something like the previous comment ("needed for wixtoolset") would be better. Remember that this code may need to be maintained some day by non-Windows-experts. They might be reassured by a short sentence or two describing what these things are and why they're needed.
There was a problem hiding this comment.
@edsantiago addressed this in the latest update. PTAL.
|
Comparing against the versions in podman right now:
|
Are the new rawhide kernel and fedora golang versions going to be trouble? |
|
Very very unlikely. |
Replace choco with dotnet for wix installation as choco doesn't have anything newer than v3.14. Ref: https://community.chocolatey.org/packages/wixtoolset This commit also uses an updated windows image that installs the latest wix using the dotnet runtime. Ref: containers/automation_images#354 Resolves: RUN-2055 Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
|
Better, thank you! |
lsm5
changed the title
|
hmm, looks like I need to add an additional package https://www.nuget.org/packages/WixToolset.Heat in the windows image too. ughhhh |
|
Cirrus CI build successful. Found built image names and IDs:
|
|
(No package diffs against previous build) |
|
FYI: Since Ed and I will both be gone Friday, and myself all of next week I said it's okay for Lokesh to merge this PR assuming the run through podman CI passes. |
Replace choco with dotnet for wix installation as choco doesn't have anything newer than v3.14. Ref: https://community.chocolatey.org/packages/wixtoolset This commit also uses an updated windows image that installs the latest wix using the dotnet runtime. Ref: containers/automation_images#354 Resolves: RUN-2055 Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Replace choco with dotnet for wix installation as choco doesn't have anything newer than v3.14. Ref: https://community.chocolatey.org/packages/wixtoolset This commit also uses an updated windows image that installs the latest wix using the dotnet runtime. Ref: containers/automation_images#354 Resolves: RUN-2055 Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
wix3 is EOL and choco doesn't support installing wix > 3.14. So, this commit installs the `dotnet` runtime and uses dotnet to install the latest wix in the windows image. Resolves: RUN-2055 Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
|
@lsm5 I have no way to know if this build is successful for the purposes you intend. If you're happy with it, feel free to merge. |
wix3 is EOL and choco doesn't support installing wix > 3.14.
So, this commit installs the
dotnetruntime and uses dotnet to installthe latest wix in the windows image.
Resolves: RUN-2055