WIP: Use podman pull to fetch containers
#215
Open
+826
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo: Now, we can also expose every single And also for example, we can optimize pushes and pulls between the bootc storage and the default |
cgwalters
force-pushed
the
podman-pull
branch
5 times, most recently
from
91856eb
to
0415f12
Compare
This was referenced Dec 5, 2023
Closed
This was referenced Mar 26, 2024
Open
This was referenced May 22, 2024
cgwalters
commented
May 31, 2024
lib/src/ostree_authfile.rs
Outdated
| @@ -0,0 +1,72 @@ | |||
| //! # Copy of the ostree authfile bits as they're not public | |||
There was a problem hiding this comment.
Let's do ostreedev/ostree-rs-ext#636
We'll use this even in cases where we don't have the `install` feature. Signed-off-by: Colin Walters <walters@verbum.org>
See containers#147 (comment) With this bootc starts to really gain support for a different backend than ostree. Here we basically just fork off `podman pull` to fetch container images into an *alternative root* in `/ostree/container-storage`, (Because otherwise basic things like `podman image prune` would delete the OS image) This is quite distinct from our use of `skopeo` in the ostree-ext project because suddenly now we gain support for things implemented in the containers/storage library like `zstd:chunked` and OCI crypt. *However*...today we still need to generate a final flattened filesystem tree (and an ostree commit) in order to maintain compatibilty with stuff in rpm-ostree. (A corrollary to this is we're not booting into a `podman mount` overlayfs stack) Related to this, we also need to handle SELinux labeling. Hence, we implement "layer squashing", and then do some final "postprocessing" on the resulting image matching the same logic that's done in ostree-ext such as `etc -> usr/etc` and handling `/var`. Note this also really wants ostreedev/ostree#3106 to avoid duplicating disk space. Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
|
Ok, I've pushed my rebased and seemingly-working fork onto the original here so I can continue to iterate here instead of off in my own world. I know there are things that are still half-done or hacked-around that needs cleaned up, but this is at least something people can look at and build and play around with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep in https://github.com/containers/bootc/pull/214Move pull code into deploy
WIP: Use
podman pullto fetch containersSee #147 (comment)
With this bootc starts to really gain support for a different backend
than ostree. Here we basically just fork off
podman pulltofetch container images into an alternative root in
/ostree/container-storage,(Because otherwise basic things like
podman image prunewoulddelete the OS image)
This is quite distinct from our use of
skopeoin the ostree-ext projectbecause suddenly now we gain support for things
implemented in the containers/storage library like
zstd:chunkedandOCI crypt.
However...today we still need to generate a final flattened
filesystem tree (and an ostree commit) in order to maintain
compatibilty with stuff in rpm-ostree. (A corrollary to this is
we're not booting into a
podman mountoverlayfs stack)Related to this, we also need to handle SELinux labeling.
Hence, we implement "layer squashing", and then do some final
"postprocessing" on the resulting image matching the same logic
that's done in ostree-ext such as
etc -> usr/etcand handling/var.Note this also really wants
ostreedev/ostree#3106
to avoid duplicating disk space.