Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: Fix accessing to layer without lock in c/storage #4254

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: Fix accessing to layer without lock in c/storage #4254

wants to merge 1 commit into from

Conversation

tyler92
Copy link

@tyler92 tyler92 commented Sep 16, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Update c/storage from containers/storage#1351 to check CI tests.

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tyler92
Once this PR has been reviewed and has the lgtm label, please assign vrothberg for approval by writing /assign @vrothberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tyler92 tyler92 force-pushed the check-storage-panic branch 2 times, most recently from 652e599 to 4754dad Compare September 18, 2022 10:31
@tyler92
DO NOT MERGE: Fix accessing to layer without lock in c/storage
ee05557 
> go mod edit -replace github.com/containers/storage=github.com/tyler92/storage@fix-panic-in-layers
> make vendor

Signed-off-by: Mikhail Khachayants <tyler92@inbox.ru>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@openshift-merge-robot
Copy link
Collaborator

@tyler92: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Sep 26, 2022

@tyler92 This PR needs to be rebased or closed.

@tyler92 tyler92 closed this Sep 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked - please file new issue/PR needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyler92 @openshift-merge-robot @rhatdan