Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Packit: enable c10s downstream sync #5514

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 3, 2024

This commit will enable downstream syncing to CentOS Stream 10. The centos maintainer will need to manually run packit propose-downstream and centpkg build until better centos integration is in place.

This commit also builds both rhel9 and centos9 copr rpms so we can check for things like differences in golang compiler.

What type of PR is this?

/kind other

What this PR does / why we need it:

enables downstream syncing to c10s

How to verify it

can't be verified pre-merge. After a release is cut, the centos maintainer will run packit propose downstream -p buildah-centos to trigger a centos merge request.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

1 similar comment
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member Author

lsm5 commented May 3, 2024

@nalind @rhatdan PTAL. the centos stream jobs are failing on HashSign but the change itself should be good to go.

@lsm5 lsm5 marked this pull request as ready for review May 3, 2024 18:06
@lsm5 lsm5 marked this pull request as draft May 7, 2024 17:28
@lsm5 lsm5 marked this pull request as ready for review May 7, 2024 17:49
@lsm5
Copy link
Member Author

lsm5 commented May 7, 2024

@nalind @TomSweeneyRedHat PTAL .

@TomSweeneyRedHat
Copy link
Member

All kinds of red test unhappiness @lsm5

@lsm5
Copy link
Member Author

lsm5 commented May 8, 2024

All kinds of red test unhappiness @lsm5

Yes, those are expected because of the undefined: ecdsa.HashSign FIPS issue that's being worked on. Having both RHEL (EPEL targets) and CentOS Stream testing would mean some tests would fail at times depending on golang compiler / toolchain differences. This is actually a good thing IMHO as it provides early warnings of upcoming RHEL issues.

On the flip side, if centos stream tests pass and epel tests fail, then it's safe to say the RHEL tests will pass after sometime.

I will check with packit team if it's possible to hide / waive such tests if one includes a github comment like slash-packit ignore-foo-test

This commit will enable downstream syncing to CentOS Stream 10. The
centos maintainer will need to manually run `packit propose-downstream`
and `centpkg build` until better centos integration is in place.

This commit also builds both rhel9 and centos9 copr rpms so we can check
for things like differences in golang compiler.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Copy link
Member Author

lsm5 commented May 31, 2024

This is failing on c9s because the golang update to restore the HashSign and HashVerify symbols hasn't landed in buildroot yet. The change itself should be good to go

@nalind @rhatdan @TomSweeneyRedHat PTAL

@nalind
Copy link
Member

nalind commented Jun 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e795e68 into containers:main Jun 3, 2024
34 of 36 checks passed
@lsm5 lsm5 deleted the packit-c10s branch June 3, 2024 13:24
@lsm5
Copy link
Member Author

lsm5 commented Jun 3, 2024

/cherrypick release-1.36

@openshift-cherrypick-robot

@lsm5: new pull request created: #5561

In response to this:

/cherrypick release-1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants