Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers.conf: Add podmansh_timeout #1547

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 6, 2023

@lsm5 lsm5 force-pushed the podmansh_timeout branch 2 times, most recently from f7c461f to 0dda145 Compare July 6, 2023 14:36
@lsm5
Copy link
Member Author

lsm5 commented Jul 6, 2023

@rhatdan @vrothberg @edsantiago @Luap99 PTAL

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/testdata/containers_default.conf Outdated Show resolved Hide resolved
docs/containers.conf.5.md Outdated Show resolved Hide resolved
pkg/config/testdata/containers_default.conf Outdated Show resolved Hide resolved
pkg/config/containers.conf Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented Jul 13, 2023

@lsm5 Still working on this?

@lsm5
Copy link
Member Author

lsm5 commented Jul 13, 2023

@lsm5 Still working on this?

@rhatdan been distracted, but yes. I'll have an update and the podman PR tomorrow.

Ref: containers/podman#19140 (comment)

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5
Copy link
Member Author

lsm5 commented Jul 14, 2023

@Luap99 @rhatdan @edsantiago PTAL again.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsantiago
Copy link
Collaborator

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 17, 2023

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 307a9d0 into containers:main Jul 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants