pkg/ssh: simplify ssh.Validate #1554
Conversation
There was a problem hiding this comment.
The changes look good to my eyes but Validate does not have any unit tests. On top c/common does not presently pass Podman CI (see containers/podman#19178).
So I'd like to hold this PR until we can run this through Podman CI.
|
/hold |
That was bothering me as well. There is indirect coverage through the existing tests but it would be better to test its behavior explicitly. I will add some explicit tests for Validate in this PR. |
This removes logic which forces the socket path (if present) to start with "/run" and uses (*URL).String to reconstruct the URI after applying port and user policy. Fixes containers#1551. Signed-off-by: Doug Rabson <dfr@rabson.org>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
This removes logic which forces the socket path (if present) to start with "/run" and uses (*URL).String to reconstruct the URI after applying port and user policy. Fixes #1551.