CI: check for possible diff after make vendor #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can commit broken vendoring here because there is no actual test to verify that the vendor directory is clean after make vendor. PR[1] had a renovate bug[2] which causes it to not run go mod tidy, this was not caused by CI because of it. [1] containers#1555 [2] containers/automation#148 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
fails as expected: https://cirrus-ci.com/task/6431532089344000 |
PR[1] was merged without running go mod tidy as there was no CI check for it. [1] containers#1555 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can commit broken vendoring here because there is no actual test to verify that the vendor directory is clean after make vendor.
PR[1] had a renovate bug[2] which causes it to not run go mod tidy, this was not caused by CI because of it.
[1] #1555
[2] containers/automation#148