config: rm cni plugins dir check #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
Jul 25, 2023
danishprakash
force-pushed
the
rm-cnidir-check
branch
3 times, most recently
from
f0fe5ce
to
4d74fa6
Compare
danishprakash
commented
Jul 25, 2023
Luap99
reviewed
Jul 25, 2023
This check as part of validation errors out in conditions where Netavark is used instead of CNI which is rather misleading. Removing this check from Validation (early on) and expecting it to fail closer to time-of-use. Signed-off-by: danishprakash <danish.prakash@suse.com>
danishprakash
force-pushed
the
rm-cnidir-check
branch
from
4d74fa6
to
fbea6d9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danishprakash, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check as part of validation errors out in conditions where Netavark is used instead of CNI which is rather misleading. Removing this check from Validation (early on) and expecting it to fail closer to time-of-use.
Closes containers/podman#19327