libnetwork/etchosts: add docker.internal dns entries #1592
Conversation
Some tools hard code the `host.docker.internal` dns name so it is not possible to run them with podman right now. Adding the entry is simple so we should support it for better compatibility. see containers/podman#19361 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
👍 |
|
Let's wait for a final head nod from @baude. He shared some thoughts today about this feature. |
|
seems like I am in the minority again /lgtm |
|
If you talk about issues in meetings not everyone is part of and then not write any points/conclusion down in the issue then I or anybody else not part of whatever meetings cannot know anything about that. I will continue to just pick up upstream issues if they are a quick fix so please make sure to put whatever thoughts you have on open issues/PRs in writing. |
Some tools hard code the
host.docker.internaldns name so it is not possible to run them with podman right now. Adding the entry is simple so we should support it for better compatibility.see containers/podman#19361