Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup getDefaultMachineUser|Image #1611

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

baude
Copy link
Member

@baude baude commented Aug 11, 2023

small refactoring for #1603 adn #1608 where we no longer have operating system differences.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

small refactoring for containers#1603 adn containers#1608 where we no longer have operating
system differences.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Aug 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit ff7a76c into containers:main Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants