libnetwork/cni: use 'ifconfig -j' on FreeBSD if it is supported #1619
Conversation
This allows us to use a single jail for containers with networking since CNI can initialise the network without needing a separate jail to own the network namespace. Signed-off-by: Doug Rabson <dfr@rabson.org>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@dfr Do you have any plans to migrate the network code to the netavark backend? I am happy to chat with you about it if you need any help. We plan to remove CNI support sooner or later (I cannot give you any timeline on that yet) so it would be unfortunate if we need to keep it around only in the freebsd code.
Regardless this change LGTM
|
/lgtm |
Moving to netavark is possible - FreeBSD added support for AF_NETLINK a while ago and its available in FreeBSD 13.2 and later. It would need AF_NETLINK support for FreeBSD to be added to rust-lang/libc which should make it possible to use the same netlink crates as Linux. I'm not sure when I will have the time for it though - I'm still concentrating on stabilising and testing the FreeBSD podman port as well as working on prototype ports for cri-o and kubernetes. |
|
Yes this is nothing that needs to happen immediately. I just wanted to let you know in case you wasn't aware so that you do not spend time on a new CNI feature just for us to remove it later. We can certainly keep the CNI code around for freebsd until we have netavark working with freebsd. |
This allows us to use a single jail for containers with networking since CNI can initialise the network without needing a separate jail to own the network namespace.