Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: close all ImageClosers #1628

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

vrothberg
Copy link
Member

Make sure to close all ImageCloser to avoid potential memory leaks.

Fixes: #1533

Make sure to close all `ImageCloser` to avoid potential memory leaks.

Fixes: containers#1533
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg
Copy link
Member Author

@rhatdan @flouthoc PTAL

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member Author

@giuseppe PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2635729 into containers:main Aug 29, 2023
7 checks passed
@vrothberg vrothberg deleted the fix-1533 branch August 29, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaks of c/image/types.Image = persistent HTTP connections
4 participants