Move libimage.ManifestList{Descriptor,Data} to libimage/define #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These structs are (for better or worse) a part of Podman's API, so podman-remote needs to include the subpackage that defines them - which is all of libimage (and c/image/v5/copy) right now. Instead, move them to libimage/define. Alternatively, maybe Podman's API should not directly depend on (unstable) c/common types?! Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Aug 28, 2023
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
See containers/podman#19783 for a Podman proof PR; and I guess the Podman API aspect should be discussed there, before this change happens. |
vrothberg
approved these changes
Aug 29, 2023
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Aug 29, 2023
+ Remove a dependency on libimage from pkg/bindings ... by updating for a c/common API change. [NO NEW TESTS NEEDED]: Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Aug 29, 2023
+ Remove a dependency on libimage from pkg/bindings ... by updating for a c/common API change. [NO NEW TESTS NEEDED]: Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These structs are (for better or worse) a part of Podman's API, so
podman-remoteneeds to include the subpackage that defines them - which is all oflibimage(andc/image/v5/copy) right now.Instead, move them to
libimage/define.Alternatively, maybe Podman's API should not directly depend on (unstable) c/common types?!
Only moves unchanged code, should not change behavior.