enable more linters #1632
Merged
enable more linters #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Selectively disable cases that I cannot touch or don't bother spending time on. Future cases will be avoided. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Document why funlen is disabled to avoid redundant work in the future trying to re-enable it. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Not changing the world but useful hygiene. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Useful micro optimizations. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Useful micro optimizations. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Useful micro optimizations. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
No rockt science but good hygiene. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
The white space linter is useful to enforce certain coding styles but is quite opinionated and probably not worth the effort. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Mostly monkey work to fix comments but there was also an error message. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
eriksjolund
reviewed
Sep 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commits. This will be a longer journey but I think a worthwhile one.