Remove ActiveDestination method to move into podman

[cgiradkar]

The method ActiveDestination was being used only by Podman and there seemed to code complications as the code is split in multiple parts. Hence, moved the code to Podman to make it more readable and efficient.

relates to: #15588

Signed-off-by: Chetan Giradkar cgiradka@redhat.com

[rhatdan]

LGTM
/approve
@giuseppe @vrothberg @ashley-cui @baude PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgiradkar, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

Going one step back:

Should we consider to ignore the existence of these environment variables here entirely? I feel using them here AND over in Podman is just making the logic more complicated than it needs to.

The function here returns whatever Podman asks for. What Podman asks for is up to Podman code to decide. I may be missing something important. @ashley-cui @rhatdan @cgiradkar what do you think?

[cgiradkar]

Going one step back:

Should we consider to ignore the existence of these environment variables here entirely? I feel using them here AND over in Podman is just making the logic more complicated than it needs to.

The function here returns whatever Podman asks for. What Podman asks for is up to Podman code to decide. I may be missing something important. @ashley-cui @rhatdan @cgiradkar what do you think?

Computationally it should not make any difference but it may lead to better code readability. Additionally if the method ActiveDestination is only getting used in Podman repo, then, I think, we can move the logic to Podman.

[ashley-cui]

LGTM

[rhatdan]

/lgtm
/hold
thanks @cgiradkar

[cgiradkar]

@rhatdan can you please re-approve? I pushed a small linter change.

[rhatdan]

Please clean this up, we want to get this merged before we cut the release.

[Luap99]

Please clean this up, we want to get this merged before we cut the release.

I see no reason to declare this as blocker.

[rhatdan]

No it is not a blocker, but does fix a Bug that would be nice to get fixed before the release. When I mark something as 4.7 it is not a blocker, but something that we should consider for 4.7.

[cgiradkar]

The method ActiveDestination was being used only by Podman and there seemed to code complications as the code is split in multiple parts. Hence, moved the code to Podman to make it more readable and efficient.

[rhatdan]

/lgtm

[rhatdan]

/hold cancel

[vrothberg]

This commit won't compile in Podman anymore. Please open a PR against Podman ASAP to clean things up.

[cgiradkar]

Opened a PR #20084 in podman, waiting for CI to do its magic.