pkg/config: do NOT set StaticDir and VolumeDir #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not correctly and inconcistently being used by Podman making it super hard to know what's going on. Just remove them for now and deal with the remaining chaos in subsequent changes in common and Podman. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Let callers (i.e., Podman) decide which defaults to chose. This way, callers know when to override defaults (i.e., when the values are empty). Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Podman PR: containers/podman#20088 |
Luap99
reviewed
Sep 21, 2023
|
/lgtm |
|
/hold cancel |
|
Can merge. The last remaining failure in containers/podman#20088 is fixed locally. So I can do a final push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let callers (i.e., Podman) decide which defaults to chose. This way,
callers know when to override defaults (i.e., when the values are
empty).
Signed-off-by: Valentin Rothberg vrothberg@redhat.com
There's also another commit removing unused fields.
Opened as a draft, as this needs a vendor-PR in Podman.