Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: import packages only once #1665

Merged
merged 1 commit into from
Sep 27, 2023
Merged

chore: import packages only once #1665

merged 1 commit into from
Sep 27, 2023

Conversation

testwill
Copy link
Contributor

No description provided.

vrothberg
vrothberg reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Can we remove the stderrors alias and just use the errors package instead?

@vrothberg
Copy link
Member

Please use your real name to sign the commit as requested in the contributing guidelines.

@testwill
chore: import packages only once
02d3a03 
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@testwill
Copy link
Contributor Author

guoguangwu is real name

@vrothberg
Copy link
Member

guoguangwu is real name

My apologies.

vrothberg
vrothberg approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@Luap99 @flouthoc PTAL

flouthoc
flouthoc approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, testwill, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4619314 into containers:main Sep 27, 2023
7 checks passed
@testwill testwill deleted the pkg-import branch September 27, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flouthoc flouthoc flouthoc approved these changes

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@testwill @vrothberg @flouthoc @openshift-merge-robot