Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnetwork/cni: ignore ENOENT while reading networks #1668

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 27, 2023

At this point we already read the config file but here we have to get timestamp here so we can hit another ENOENT if it was removed in the meantime. Just ignore this and do not log an error as this is normal behavior when another process is deleting a network in parallel.

Fixes containers/podman#20173

At this point we already read the config file but here we have to get
timestamp here so we can hit another ENOENT if it was removed in the
meantime. Just ignore this and do not log an error as this is normal
behavior when another process is deleting a network in parallel.

Fixes containers/podman#20173

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Collaborator

LGTM, thank you!

@mheon
Copy link
Member

mheon commented Sep 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 9342cdd into containers:main Sep 27, 2023
7 checks passed
@Luap99 Luap99 deleted the cni-race branch September 27, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e CNI tests: race? conflist could not be converted to a libpod config
5 participants