pkg/config: use empty default for db_backend #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft as this will break podman until I open a PR to fix the detection logic there. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
Podman should default to sqlite for new installs, however to not break upgrades we should detect if a boltdb database exists and use that in such case. Now in order to distinguish between an explicitly set "sqlite" and "boltdb" and nothing set we use an empty default. With that podman can know if we really should use the default or if it was configured for a db explicitly. The actual detection logic must be implemented in podman as we only know the file locations there. This commit also drops the unused StateType as this was not used at all. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
This should be good to do, podman tests are happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman should default to sqlite for new installs, however to not break upgrades we should detect if a boltdb database exists and use that in such case. Now in order to distinguish between an explicitly set "sqlite" and "boltdb" and nothing set we use an empty default.
With that podman can know if we really should use the default or if it was configured for a db explicitly. The actual detection logic must be implemented in podman as we only know the file locations there.
This commit also drops the unused StateType as this was not used at all.