Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/fsnotify/fsnotify to v1.7.0 #1705

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 22, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/fsnotify/fsnotify require minor v1.6.0 -> v1.7.0

Release Notes

fsnotify/fsnotify (github.com/fsnotify/fsnotify)

v1.7.0

Compare Source

This version of fsnotify needs Go 1.17.

Additions
  • illumos: add FEN backend to support illumos and Solaris. (#​371)

  • all: add NewBufferedWatcher() to use a buffered channel, which can be useful in cases where you can't control the kernel buffer and receive a large number of events in bursts. (#​550, #​572)

  • all: add AddWith(), which is identical to Add() but allows passing options. (#​521)

  • windows: allow setting the ReadDirectoryChangesW() buffer size with fsnotify.WithBufferSize(); the default of 64K is the highest value that works on all platforms and is enough for most purposes, but in some cases a highest buffer is needed. (#​521)

Changes and fixes
  • inotify: remove watcher if a watched path is renamed (#​518)

    After a rename the reported name wasn't updated, or even an empty string. Inotify doesn't provide any good facilities to update it, so just remove the watcher. This is already how it worked on kqueue and FEN.

    On Windows this does work, and remains working.

  • windows: don't listen for file attribute changes (#​520)

    File attribute changes are sent as FILE_ACTION_MODIFIED by the Windows API, with no way to see if they're a file write or attribute change, so would show up as a fsnotify.Write event. This is never useful, and could result in many spurious Write events.

  • windows: return ErrEventOverflow if the buffer is full (#​525)

    Before it would merely return "short read", making it hard to detect this error.

  • kqueue: make sure events for all files are delivered properly when removing a watched directory (#​526)

    Previously they would get sent with "" (empty string) or "." as the path name.

  • kqueue: don't emit spurious Create events for symbolic links (#​524)

    The link would get resolved but kqueue would "forget" it already saw the link itself, resulting on a Create for every Write event for the directory.

  • all: return ErrClosed on Add() when the watcher is closed (#​516)

  • other: add Watcher.Errors and Watcher.Events to the no-op Watcher in backend_other.go, making it easier to use on unsupported platforms such as WASM, AIX, etc. (#​528)

  • other: use the backend_other.go no-op if the appengine build tag is set; Google AppEngine forbids usage of the unsafe package so the inotify backend won't compile there.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 22, 2023
@renovate renovate bot force-pushed the renovate/github.com-fsnotify-fsnotify-1.x branch from c4277a3 to 2f4b79a Compare October 23, 2023 06:57
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/github.com-fsnotify-fsnotify-1.x branch from 2f4b79a to 2cfda9d Compare October 23, 2023 07:03
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d3170cb into main Oct 23, 2023
7 checks passed
@renovate renovate bot deleted the renovate/github.com-fsnotify-fsnotify-1.x branch October 23, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants