Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: add !remote tag #1708

Merged
merged 1 commit into from
Oct 23, 2023
Merged

libimage: add !remote tag #1708

merged 1 commit into from
Oct 23, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 23, 2023

To prevent the podman remote client from using libimage which causes a lot of bloat due the c/image and c/storage dependencies add the !remote tag.

This will cause a hard compile time failure if the remote client ends up pulling in libimage.

Fixes #1702

To prevent the podman remote client from using libimage which causes a
lot of bloat due the c/image and c/storage dependencies add the
`!remote` tag.

This will cause a hard compile time failure if the remote client ends up
pulling in libimage.

Fixes containers#1702

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Oct 23, 2023

LGTM
@vrothberg PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2023
@openshift-ci openshift-ci bot merged commit 8d0bd25 into containers:main Oct 23, 2023
7 checks passed
@Luap99 Luap99 deleted the remote branch October 23, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: add !remote build tags to libimage
3 participants