Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups: remove unused files #1716

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Oct 27, 2023

they are a dup of the _linux.go version. Move the linux-only functions to the _linux.go file.

[NO NEW TESTS NEEDED]

@rhatdan
Copy link
Member

rhatdan commented Oct 27, 2023

Tests blowing up?

they are a dup of the _linux.go version.  Move the linux-only
functions to the _linux.go file.

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe marked this pull request as ready for review October 27, 2023 12:47
@giuseppe giuseppe changed the title cgroups: remove unused file cgroups: remove unused files Oct 27, 2023
@giuseppe
Copy link
Member Author

I had to remove even more stuff.

@rhatdan
Copy link
Member

rhatdan commented Oct 27, 2023

LGTM
@vrothberg @Luap99 PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I love commits reducing the lines of code.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 2346b88 into containers:main Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants