Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masked paths and readonly paths to config #1717

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 27, 2023

Podman and Buildah have gone out of sync, this will allow us to make sure they stay in sync.

Podman and Buildah have gone out of sync, this will allow us to make
sure they stay in sync.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Oct 27, 2023

@mheon PTAL

@mheon
Copy link
Member

mheon commented Oct 27, 2023

LGTM. We'll need to add a quick check to Podman once this merges to not double-add the masked path if it already exists, but that's simple enough.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ecc52e4 into containers:main Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants