UserConnection is used by non linux platforms

[rhatdan]

Take this oppurtunity to remove Get prefix on functions in cgroups.

[rhatdan]

@giuseppe PTAL, still broken.

[giuseppe]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Should this have the breaking-change label? What API guarantees does this library offer?

[rhatdan]

None right now. I am working on getting this merged into Podman right now, so I wanted to take the liberty to change these function calls.

[mtrmac]

No API guarantees. Still, disruptive changes have a cost in consumers. (Also, IIRC the Go convention is to avoid the Get prefix for trivially cheap getters, not for routines that may block indefinitely or do heavy I/O. I don’t know where some of the affected functions fall on this spectrum.) Keeping the existing function names around, marking them as deprecated, might be a bit less disruptive for consumers — more work overall, but less urgency and stress during vendoring.

On the topic of the change itself, typically those platform don’t have a user-session systemd running anyway, so I’m not sure dragging in a systemd client / d-bus API dependency is necessary. But I also can’t spend the time to form an opinion on whether making this distinction compile-time or only at run-time is worth the effort.

[baude]

/lgtm