Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: attempt to guess DBUS_SESSION_BUS_ADDRESS #2002

Conversation

giuseppe
Copy link
Member

move the specific code from Podman, so that also other packages can take advantage of it.

Closes: RHEL-36146

move the specific code from Podman, so that also other packages can
take advantage of it.

Closes: RHEL-36146

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remember to remove the duplciated code from podman once this is vendored

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented May 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ec0a25c into containers:main May 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants