Packit: Fixes for RHEL, CentOS Stream and COPR, TMT: more generic testing prep steps to minimize distro conditionals #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on reviews until I verify the copr build Epoch. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
rpm epoch:version-release shows Looks like testing-farm is having issues with packit, so we can ignore all the |
|
looks like there are other issues for centos-stream builds. Hold off on reviews. |
Because of the wrong `copr_project` macro, recent crun builds on copr didn't actually include the Epoch. We should use either copr_username, copr_projectname or both. Those 2 macros are only defined on copr environments. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
CentOS Stream builds don't have epel repos configured by default because of which they can't directly fetch the wasmedge build dependency. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5
force-pushed
the
rpm-fix-copr-conditional
branch
from
bfd094c
to
5820831
Compare
Without this change, duplicate copr builds jobs are triggered on the podman-next copr for `[crun-fedora]`, `[crun-centos]`. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
This allows centos jobs to be triggered on all PRs regardless of author's level of access to the repo. RHEL jobs would still need to be triggered by repo maintainers. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5
changed the title
|
|
|
podman system tests failed. @containers/packit-build please check. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
lsm5
force-pushed
the
rpm-fix-copr-conditional
branch
from
f64b5da
to
67b87ea
Compare
Differences across distros and versions in components like dnf as well as variable package availability for bats makes idiomatic TMT hard to maintain if we're to install all dependencies using rpm packages. Fetching `bats` from upstream and simply deleting problematic yum repos instead of resorting to tricky dnf commands makes the TMT logic a lot easier to maintain. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5
force-pushed
the
rpm-fix-copr-conditional
branch
from
67b87ea
to
e676aaf
Compare
lsm5
changed the title
|
closing in favor of #1470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Because of the wrong
copr_projectmacro, recent crun builds on coprdidn't actually include the Epoch. We should use either
copr_username, copr_projectname or both. Those 2 macros are only defined
on copr environments.
Commit 2: CentOS Stream builds don't have epel repos configured by default because
of which they can't directly fetch the wasmedge build dependency.
Commit 3: Use
packages: [crun-fedora]for copr jobs on podman-next after commit to main to avoid duplicate build jobs.Commit 4: Separate rhel and centos-stream jobs to allow centos stream jobs to run for all PR authors, regardless of access levels.
Commit 5: Differences across distros and versions in components like dnf as well as variable package availability for bats makes idiomatic TMT hard to maintain if we're to install all dependencies using rpm packages. Fetching
batsfrom upstream and simply deleting problematic yum repos instead of resorting to tricky dnf commands makes the TMT logic a lot easier to maintain.Commit 6: COPR/RPM: Disable wasmedge on RHEL10 until EPEL10 is available as wasmedge is only available in epel.